-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/dbmgr: fix show attribute table for vector map from another mapset #3081
wxGUI/dbmgr: fix show attribute table for vector map from another mapset #3081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GUI shouldn't be temporarily changing mapsets. The way to do it is to use gs.create_environment
and pass that environment to db.connect.
Yes you are right, thanks for your explanation. |
I think this could still be useful if the mapset is created manually without initialization. The only thing I would perhaps modify is relying on vectname to include mapset, using find_file may be a good idea. |
Ok, I'm reopening this PR and have incorporated your suggestion. |
Fixes #3078.